It is code review time, and I offer a sample of Java code for you to critique. Can you find the problems? Read the rest of this entry »
Tag Archives: code style
Be careful what you ask for. I was reviewing some code that had absolutely no comments. I asked the developer to add some comment. So, indeed they did, however the comments added no value to the code at all. There is no point in adding comments for comments’ sake. In fact, useless comments make the code worse by adding lines without adding value. Let’s talk about what a valuable comment is. Read the rest of this entry »
This general design principle does not mean to never change anything, but to consciously create a paradigm where the same things have the same names and are accessed in the same way as much as possible. Read the rest of this entry »
This is the first of a series of posts, I want to go over some of the groundwork of what it takes to make exceptions localizable into other languages. Nothing new here, but just want to explain clearly the requirements of a localizable exception messages.
Still reviewing that code base and finding more bad patterns for use of constants, this time for error messages. This is another “don’t do this” post. Read the rest of this entry »